Skip to content

Bug 2059826 - Simplified View: Create checkbox selection for advanced columns and display how to read the results - #1069

Merged
kala-moz merged 5 commits into
mozilla:mainfrom
kala-moz:simplified-view-phase1
Aug 20, 2026
Merged

Bug 2059826 - Simplified View: Create checkbox selection for advanced columns and display how to read the results#1069
kala-moz merged 5 commits into
mozilla:mainfrom
kala-moz:simplified-view-phase1

Conversation

@kala-moz

@kala-moz kala-moz commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Deploy link

Bug 2059826

Screenshot 2026-08-18 at 17 19 34 Screenshot 2026-08-18 at 17 19 54

Summary

Introduces a beginner-friendly "simplified" results view for the Mann-Whitney-U comparison table, while keeping the full statistical detail only check-boxes away. New contributors get plain-language columns and an on-page reading guide by default; power users can reveal the advanced stats columns with specific checkboxes (persists in the url).

User-facing changes

Δ Median % (renamed from MD (%)) — now computed from the raw runs' medians ((median(new) − median(base)) / median(base) × 100), which matches both the expanded panel's bootstrap median-diff and the reference perfcompare-new-stats implementation. Formatted as a signed, 2-decimal percent (+1.08% / −2.40%); a warning icon flags non-normal distributions (the value is still shown, since the median is rank-based); shows +0.00% for a zero base median and - only when there are no runs.

Magnitude: Move the Cliff's Delta interpretation into its own "Magnitude" column (simplified view only) so users can sort and filter by effect size.

UPDATE: Significance is now a power-user column: hidden in the simplified view and toggled from the "Advanced columns" dropdown. To keep the noise signal visible by default, the Status cell shows a muted "Noise" pill above the direction chip for not-significant results, and the

Status filter gains a "Noise" option. The Noise filter value is mutually exclusive with the direction buckets: a noisy row belongs to "Noise" only, so unchecking Noise hides it and the Improvement/Regression/No change buckets match only real changes.

Advanced columns dropdown: contains independent Cliff's Delta, CLES, Significance checkboxes (either/both/neither).

"How to read the results" panel: A dismissive guide above the table explaining each column in plain English. Shown by default for new users; the close button or the "How to read the results" checkbox toggles it, and the choice is remembered.

Notable decisions / follow-ups

Defaults: simplified view and the reading panel are on by default (dismissible, remembered). Easy to flip if we'd rather not change the default for existing users.

Scope: the reading panel is on the main results view only (not the subtests drill-down) — easy to add there if wanted.

Phase 2 candidate: simplify the expanded row.

🤖 Generated with the help of Claude Code

@netlify

netlify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploy Preview for mozilla-perfcompare ready!

Name Link
🔨 Latest commit 25841bf
🔍 Latest deploy log https://app.netlify.com/projects/mozilla-perfcompare/deploys/6a8646940325c80008b316c0
😎 Deploy Preview https://deploy-preview-1069--mozilla-perfcompare.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@kala-moz
kala-moz marked this pull request as draft July 24, 2026 02:14
@kala-moz
kala-moz requested review from beatrice-acasandrei, esanuandra, gmierz and padenot and removed request for padenot July 24, 2026 02:32
@kala-moz
kala-moz marked this pull request as ready for review July 24, 2026 02:36
Comment thread src/common/constants.ts Outdated
Comment thread src/components/CompareResults/AdvancedColumnsToggle.tsx Outdated
@esanuandra

Copy link
Copy Markdown
Contributor

It looks great!

@kala-moz kala-moz changed the title Bug 2039401: Simplified view phase 1 Bug 2059826 - Simplified View: Create checkbox selection for advanced columns and display how to read the results Jul 31, 2026
Comment thread src/common/testVersions/mannWhitney.tsx Outdated
Comment thread src/common/testVersions/mannWhitney.tsx Outdated
Comment thread src/components/CompareResults/AdvancedColumnsToggle.tsx Outdated
Comment thread src/common/testVersions/studentT.tsx Outdated
@kala-moz
kala-moz force-pushed the simplified-view-phase1 branch 2 times, most recently from 52293fe to aada4b7 Compare August 5, 2026 22:23
@kala-moz
kala-moz force-pushed the simplified-view-phase1 branch from 6969361 to 1adf797 Compare August 6, 2026 21:28
Comment thread src/common/testVersions/mannWhitney.tsx Outdated
Comment thread src/reducers/ColumnPrefsSlice.ts Outdated
Comment thread src/components/CompareResults/AdvancedColumnsMenu.tsx Outdated
@kala-moz

Copy link
Copy Markdown
Contributor Author

Based on the feedback from today's sync, I will create a new row for the checkboxes so there's not so much white space in the table controls area

@beatrice-acasandrei beatrice-acasandrei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I’ve included a few minor, optional suggestions, but everything looks solid. Please feel free to merge when you see fit.

Comment thread src/reducers/ColumnPrefsSlice.ts
Comment thread src/components/CompareResults/HowToReadResults.tsx Outdated
Comment thread src/components/CompareResults/ResultsControls.tsx Outdated
Comment thread src/components/CompareResults/RevisionRow.tsx
Comment thread src/hooks/useSeedAdvancedColumnsFromUrl.ts Outdated
@kala-moz

Copy link
Copy Markdown
Contributor Author

Hey @beatrice-acasandrei Thanks for the reviews!

Update tests too

Adjust styles for new table changes

created toggle for customizing col: simple vs power view

update tests to reflect new UI/UX

add interpret results panel for simple users

render 0.00 vs - for no data in median col

update table to include significance; add difference below status

update how to read the results

Add an "Advanced columns" dropdown with independent Cliff's Delta and CLES

Hidden by default; the choice persists to localStorage. Available on both the main and subtests pages.

Persist advanced-column selection in the URL

resolved PR review comments

Add sortable/filterable Magnitude column and widen the results table
@kala-moz
kala-moz force-pushed the simplified-view-phase1 branch from 458bd0a to 25841bf Compare August 20, 2026 00:13
@kala-moz
kala-moz merged commit cc86b88 into mozilla:main Aug 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants